Repository navigation
fix(doctor): tell an empty or no-Studio-Pro Windows/macOS machine the truth - #775
Conversation
… truth The Mendix CDN publishes Linux mxbuild only, so off Linux `doctor.sh --install` cannot download a gate that runs. Doctor said otherwise, and its project help text named `mxcli init` as the source of a new .mpr (init creates no app). - --install on macOS/Git Bash: no ~800 MB plan, no `mxcli setup mxbuild` call; says install Studio Pro in the app's version or use the Dev Container. - --install with no .mpr: says there is no app yet and how to make one (Studio Pro New app > Blank outside OneDrive, or `mxcli new` before `init`). - Claude Code permissions section: "skipped" when Claude Code is not on the machine (MXTK_CLAUDE=1 forces it), instead of two WARNs a non-Claude agent cannot act on. - README no-Studio-Pro note: Linux only; empty-folder order. - tests/wave2/test-doctor-no-app-no-sp.sh: 15/15 (10 fail on the old doctor). - Three upstream drafts in bug-logs/pending-github-issues/. Field: a customer's Windows 11 / Git Bash setup, empty OneDrive folder, no Studio Pro, no Docker, non-Claude agent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…m pinned for the fake OS Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review: MERGE-AFTER-FIX. CI Value: Fixes the reported dead end.
Regression risk:
Correctness:
Context cost: 66196 → 66196 words (measured on both). Time cost: nothing per build row. CI adds about 22 s for the new fixture. Exact fixes required:
Generated by Claude Code |
…Linux text; doctor-triage cache lane is Linux-only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review fixes pushed in f891bc8, at the maintainer's request:
I did not re-run the fixtures locally. CI Generated by Claude Code |
…otstrap # Conflicts: # CHANGELOG.md
|
Review: MERGE (re-review). All three fixes from the first review are in and correct (f891bc8). The master merge (9a1feb3) only joins the two CHANGELOG sides. CI Value: The PR fixes the reported dead end. Off Linux it no longer plans a download that cannot work, and an empty folder now gets "no app yet" with the Regression risk:
Correctness: Run in a detached worktree at 9a1feb3. The two hook fixtures and stale-hooks also pass with no
Nit, not blocking: Context cost: 66271 → 66271 words (measured). Time cost: nothing per build row. Generated by Claude Code |
Direct lane
What changed and why (one paragraph):
A customer's Windows 11 / Git Bash setup (empty folder under OneDrive, no Studio Pro, no Docker, a non-Claude agent) hit four doctor FAILs from the missing
.mpr, then followed doctor's advice ("No Studio Pro needed for the gate: --install downloads the standalone toolchain") intomxcli new, which left a 373 MB partial Linux mxbuild and no app. Off Linux that advice is wrong: the Mendix CDN publishes Linux mxbuild only (mxcliNativeMxBuildForSetup, #916), andmxcli setup mxbuildrefuses there. Doctor now (1) on macOS/Git Bash skips the ~800 MB plan and the deadsetup mxbuildcall, and says install Studio Pro in the app's version or use the Dev Container; (2) with no.mpr, says there is no app yet and how to create one (Studio Pro New app > Blank outside OneDrive, ormxcli newbeforemxcli init); (3) no longer namesmxcli initas the source of a new.mpr; (4) reports the Claude Code permissions section as "skipped" when Claude Code is not on the machine (MXTK_CLAUDE=1forces it). README's no-Studio-Pro note now says Linux only. Three upstream drafts added tobug-logs/pending-github-issues/(not filed).Impact
bin/doctor.shonly (no_common.sh/exec.shchange). Uses existingmxtk_model_version. New envMXTK_CLAUDE(optional). No order dependency on open PRs.Field evidence: observed on a customer's Windows 11 / Git Bash machine (described above, from the customer's setup report). The changed doctor has not yet run on a real Windows machine; Windows and macOS are simulated with a fake
uname+MXTK_PLATFORMand a call-logging stub mxcli. A supervised re-run on that machine is planned.Tests
tests/wave2/test-doctor-no-app-no-sp.sh: 21/21. On the previous doctor 10 of its checks fail (the stub showssetup mxbuildcalled on Windows and macOS). Covers: Windows empty folder, Windows/macOS app without Studio Pro, Linux unchanged, macOS and Windows WITH Studio Pro unchanged, no-Claude section skipped.Existing:
test-doctor-mxcli-arch10/10,test-doctor-portable24/24,test-doctor-mxcli-latest12/12,test-doctor-stale-hooks7/7.check-scripts137/137,check-portabilityclean, leak guard clean,check-pr-disciplineclean.Local
run-all.shwas stopped at its 1-hour limit (102 of 223 fixtures run). Every failure it showed was compared on an untouchedorigin/masterworktree, with the same count on both: app-readiness, app-restart, baseline-loosen-lock, common-root-multiapp, common-windows, company-brain, doctor-bench, doctor-gate-selftest, file-bugs (local macOS environment). bug12-sync fails on both with varying counts (flaky locally); it testssync-project.sh, untouched here. T3 left to CI.No client data anywhere in the diff
Size cap: 7 files; ~190 lines excluding CHANGELOG and drafts
Test tier reached: T1 (new fixture + related doctor fixtures); T2 pending (real Windows re-run)
Both platforms considered (macOS, Git Bash, Linux, WSL keeps the Linux path); both layouts (
toolchain_skip_reasonchecks root andapp/)CHANGELOG.mdline appended, creditedNo new bug numbers
🤖 Generated with Claude Code